[viewer-development-commits] commit/viewer-development: 3 new changesets

Automatic commit notification for viewer-development viewer-development-commits at lists.secondlife.com
Thu Nov 4 07:51:25 PDT 2010

3 new changesets in viewer-development:

changeset:   r13296:8ec71fe09774
user:        andrew_productengine
date:        2010-11-03 17:23:53
summary:     STORM-472 Fixed crash that happened while decoding jpg image.

In case of files provided in ticket problem occured in libjpeg's jpeg_start_decompress(to be more specofic- inside it's _jinit_color_deconverter()) because if cinfo's out_color_space is RGB, then jpeg_color_space can't be JCS_YCCK (JCS_YCCK jpeg_color_space is possible for JCS_CMYK out_color_space). So when the combination of RGB and JCS_YCCK was encountered, jpeglib called ERREXIT() inside which exit() was called and viewer crashed.

- Checking for this combination before calling jpeg_start_decompress() would solve this problem in this specific case, but there are a lot of possible error combinations which cause libjpeg to exit and thus crash viewer, so copypasting checks from it into viewer code would be cumbersome, uneffective and ugly. So another approach was used instead- by default libjpeg calls exit() after encountering an error, but user can provide his own error handling function instead. on_jpeg_error() function was added in fix for this. It sets true a boolean flag that is used to determine whether there were errors in getImageDimensionsJpeg(), and this function's return value depends on it.
affected #:  1 file (559 bytes)

changeset:   r13297:fca48d35bd3a
user:        vadim_productengine
date:        2010-11-02 19:26:38
summary:     STORM-422 FIXED Added command line option "-disablecrashlogger" to disable crash logger.

This is a patch originally written by Robin Cornelius.
I made it work with Google Breakpad.
affected #:  5 files (1.6 KB)

changeset:   r13298:e6dbb66dae8b
user:        oz_linden
date:        2010-11-03 19:53:29
summary:     pull fix for STORM-422
affected #:  1 file (20 bytes)

Repository URL: http://bitbucket.org/lindenlab/viewer-development/

This is a commit notification from bitbucket.org.
You are receiving this because you have the service 
enabled, addressing the recipient of this email.

More information about the viewer-development-commits mailing list