[sldev] Texture caching

Jason Giglio gigstaggart at gmail.com
Tue Mar 20 13:59:36 PDT 2007


Dzonatas wrote:
> Jason Giglio wrote:
>> Attached is the code cleanup patch, I haven't submitted it to LL 
>> because I plan on making a lot more changes eventually.
> This is minor. Don't need braces for simple code-flow.  In you patch you 
> have:
> 
> if(mReadOnly)
> {
>    return;
> }

I know, I was following the standards used elsewhere in the file.

> Also, in your patch:
> 
> -    if (num_entries * (S32)sizeof(Entry) != filesize)
> +
> +    //make sure the file is a multiple of the Entry size
> +    if( filesize % (S32)sizeof(Entry) != 0)
> 
> No need for your comment, as I can read the code just fine. However, I 
> prefer the way you used the "%".

Considering the file has nearly no comments right now, I figured 
anything was an improvement.  The way the code was written before made 
it less obvious what it was doing anyway.

-Jason


More information about the SLDev mailing list