[opensource-dev] Review Request: STORM-1600 Error in focus while naming a new item - may lead to content loss

Vadim ProductEngine vsavchuk at productengine.com
Fri Sep 16 09:14:12 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/478/
-----------------------------------------------------------

Review request for Viewer and Richard Nelson.


Summary
-------

Folder view stole "Delete" key presses from the line editor when renaming a newly created inventory item.

Reason:
LLFocusMgr::setKeyboardFocus() which is called from LLLineEditor::setFocus()
makes the folder view the edit menu handler, thus it receives the Delete key
presses instead of the line editor.

Fix:
Make sure the line editor becomes the edit menu handler whenever it's focused,
no matter is it a child of a folder view or not.


This addresses bug STORM-1600.
    http://jira.secondlife.com/browse/STORM-1600


Diffs
-----

  indra/llui/lllineeditor.cpp 656d988266e8 

Diff: http://codereview.secondlife.com/r/478/diff


Testing
-------


Thanks,

Vadim

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110916/b79f2923/attachment.htm 


More information about the opensource-dev mailing list