[opensource-dev] Review Request: STORM-954 corrected patch

Merov Linden merov at lindenlab.com
Thu Mar 31 14:12:01 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/194/#review528
-----------------------------------------------------------

Ship it!


Thanks Twisted for taking my comment into account in https://bitbucket.org/Twisted_Laws/viewer-development-storm-954/changeset/7bcb336642f4

This is ready to be pull in as far as I'm concerned.

- Merov


On March 9, 2011, 3:33 p.m., Twisted Laws wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/194/
> -----------------------------------------------------------
> 
> (Updated March 9, 2011, 3:33 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> STORM-954 review had 2 patches, the second of which was approved in review process but the first patch is what went into viewer-development.  This is that second patch again. This patch modifies getAvatars() in llworld.cpp.  Note this patch becomes more important if/when avatar distances may be displayed to users in the viewer as it corrects for map data being incorrect above 1024m by using the viewer characters list to get avatar position if known and then falling back on the map data for the avatars that are beyond view range.  This patch is in the repository https://bitbucket.org/Twisted_Laws/viewer-development-storm-954
> 
> 
> This addresses bug storm-954.
>     http://jira.secondlife.com/browse/storm-954
> 
> 
> Diffs
> -----
> 
>   indra/newview/llworld.cpp aed94e854443 
> 
> Diff: http://codereview.secondlife.com/r/194/diff
> 
> 
> Testing
> -------
> 
> Proper testing with and without this patch is to have 2 or more avatars at 1050 height with other avatars on the ground under you, and the NearmeRange (debug setting) set to 4096 and the sort order in the Nearby avatars panel set to sort by distance. (A busy region like a sandbox, is a good place to test.) Without this patch, a nearby avatar will not necessarily be displayed before avatars that are further away.  With this patch, the avatar standing closest to you should show up as the first in the list.   
> 
> 
> Thanks,
> 
> Twisted
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110331/23a4889c/attachment-0001.htm 


More information about the opensource-dev mailing list