[opensource-dev] Review Request: STORM-1352 Crash in LLNearbyChatScreenChannel::showToastsBottom()

Vadim ProductEngine vsavchuk at productengine.com
Thu Jun 16 13:46:27 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/341/
-----------------------------------------------------------

Review request for Viewer.


Summary
-------

Apparently, a nearby chat toast got somehow destroyed while still remaining in the list of active toasts.
Attempt to sort active toasts in showToastsBottom() then triggered the crash.

I don't know how to reproduce the crash, i.e. force destroying a toast in a way that its onClose() method (which would remove references to the toast) isn't called.
So we'll just remove references to the toast whenever it's destroyed.


This addresses bug STORM-1352.
    http://jira.secondlife.com/browse/STORM-1352


Diffs
-----

  indra/newview/llnearbychathandler.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/341/diff


Testing
-------


Thanks,

Vadim

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110616/88487553/attachment.htm 


More information about the opensource-dev mailing list