[opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations

Seth ProductEngine slitovchuk at productengine.com
Mon Dec 20 13:47:20 PST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/32/
-----------------------------------------------------------

(Updated 2010-12-20 13:47:20.663157)


Review request for Viewer.


Changes
-------

- Added supported glob wildcards matching description.
- Fixed leading '*' translation to regex to avoid matching leading '.' in file names.
- Fixed '?' escaping.
- Added incorrect braces usage handling. Added related test cases.
- Fixed character ranges complementation with '!'. Added related test cases.


Summary
-------

Fixed LLDir unit test which failed for some complex wildcard combinations.
Added a class implementing directory entries iteration with pattern matching which is used in unit tests instead of LLDir::getNextFileInDir.

This code has been run on Linux only. It should be tested under other platforms and more test cases should be provided. For example changing directory contents while iterating through it.


This addresses bug STORM-550.
    http://jira.secondlife.com/browse/STORM-550


Diffs (updated)
-----

  indra/cmake/Boost.cmake 794ad1fc71d1 
  indra/llvfs/CMakeLists.txt 794ad1fc71d1 
  indra/llvfs/lldiriterator.h PRE-CREATION 
  indra/llvfs/lldiriterator.cpp PRE-CREATION 
  indra/llvfs/tests/lldir_test.cpp 794ad1fc71d1 

Diff: http://codereview.secondlife.com/r/32/diff


Testing
-------


Thanks,

Seth

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101220/f116e6e8/attachment.htm 


More information about the opensource-dev mailing list