[opensource-dev] Review Request: STORM-524 : Refresh L$ balance

Aleric Inglewood Aleric.Inglewood at gmail.com
Thu Dec 16 09:11:38 PST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/6/#review37
-----------------------------------------------------------

Ship it!


> 99% chance that this is correct (not counting the added line with trailing white space ;).

Something that can impossibly be harmful, but what made me wonder, is that before
getChild<LLTextBox>("balance") never has setVisible called in the old code, but
in the new code apparently needs it (definitely looking logical from the context
where it is added). But I suppose that it's irrelevant.


- Aleric


On 2010-12-10 16:21:57, Merov Linden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/6/
> -----------------------------------------------------------
> 
> (Updated 2010-12-10 16:21:57)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Since the L$ balance can be updated by events outside the viewer entirely (purchase of L$ on web) and since we do not pool or receive notifications for this, I implemented a simple "click to refresh" event on the LLTextBox holding the L$ balance value (proposed by Q in JIRA).
> I modified the tooltip to reflect this new functionality.
> 
> 
> This addresses bug STORM-524.
>     http://jira.secondlife.com/browse/STORM-524
> 
> 
> Diffs
> -----
> 
>   indra/newview/llbuycurrencyhtml.cpp 8668b574c1f3 
>   indra/newview/llfloaterbuycurrency.cpp 8668b574c1f3 
>   indra/newview/llfloaterbuycurrencyhtml.cpp 8668b574c1f3 
>   indra/newview/llstatusbar.h 8668b574c1f3 
>   indra/newview/llstatusbar.cpp 8668b574c1f3 
>   indra/newview/skins/default/xui/en/panel_status_bar.xml 8668b574c1f3 
> 
> Diff: http://codereview.secondlife.com/r/6/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Merov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20101216/ef95916e/attachment.htm 


More information about the opensource-dev mailing list