[JIRA] Commented: (VWR-13511) Occasional crashes in OpenJPEG
Cummere Mayo (JIRA)
no-reply at lindenlab.cascadeo.com
Thu Jan 14 13:47:32 PST 2010
[ http://jira.secondlife.com/browse/VWR-13511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=159768#action_159768 ]
Cummere Mayo commented on VWR-13511:
is this still ongoing or can I close it out?
> Occasional crashes in OpenJPEG
> Key: VWR-13511
> URL: http://jira.secondlife.com/browse/VWR-13511
> Project: 1. Second Life Viewer - VWR
> Issue Type: Bug
> Affects Versions: Source code, Snowglobe 1.0
> Reporter: Rob Linden
> Assignee: Merov Linden
> Attachments: VWR-13511-logtime.patch
> In our crash reporter, we're seeing occasional crashes in OpenJPEG. Robin Cornelius says: "Certainly some of us have seen this fairly frequently who are building ourselves and it usually is triggers from the LLImageJ2COJ::getMetadata() during some where in opj_image_destroywhen a wild pointer is freed (possible also related to a bad image being fed to decode). This is fixed in openjpeg SVN and i think those of us on #opensl who are building http-texture already have this patched (or at least a good few do). Although its possible (I would need to confirm) that we see it because this was introduced in openjpeg 1.3 and LL are still on 1.2 internally and also this could explain why we don't see any other crashes here.
> Looking at http://www.openjpeg.org/websvn/filedetails.php?repname=OpenJpeg&path=%2Ftrunk%2Flibopenjpeg%2Fimage.c&rev=0&sc=0
> the opj_free(image->comps);
> is the offending line, note in the SVN web view the structures are
> allocated with opj_calloc() where as the older code uses opj_malloc()
> which does not null the pointers.
> There may also need to be some viewer sanity checking here as well as
> various image-> members are used in LLImageJ2COJ::getMetadata() and
> although i've not see a crash directly because of their use after
> patching openjpeg its probably worth investigating to ensure no edge
> case is creeping in here.
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://jira.secondlife.com/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the Jira-notify